Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dll_setup overrides not working as expected #56

Closed
pingubot opened this issue Feb 3, 2018 · 4 comments
Closed

dll_setup overrides not working as expected #56

pingubot opened this issue Feb 3, 2018 · 4 comments
Labels

Comments

@pingubot
Copy link
Contributor

pingubot commented Feb 3, 2018

Hi,

afaik, the script is creating links from d3d11.dll and dxgi.dll in system32 and syswow64 to the correpsonding d3d11_vk.dll and dxgi_vk.dll files.

Sadly this is not enough,
d3d11_vk.dll wants to load dxgi_vk.dll . So if you only have dxgi.dll in system32or syswow64, dxvk will not work and the log will complain about : cannot load d3d11.dll cause dxgi_vk.dll is missing.

As long as d3d11_vk.dll wants to load dxgi_vk.dll a workaround would be to create an extra symlink for dxgi_vk.dll . If there are some cross dependencies, also linking d3d11_vk.dll directly would help.

Btw, i would like to improve your script to have the possibility to rollback the override changes as well but i have no idea how meson works, Would be a diff useful for you ?

Cu,
Christian

@Raffarti
Copy link
Contributor

Raffarti commented Feb 3, 2018

Another solution would be adding the d3d11_vk.dlls path to wine PATH, which currently can be achieved by using redirection part of the script. Adding a way to revert overrides shouldn't be a problem.

@doitsujin doitsujin added the bug label Feb 3, 2018
@doitsujin
Copy link
Owner

Creating yet another symlink is not an option because it would just manifest how broken the install process currently is. I suggest renaming the DLLs back to d3d11.dll and dxgi.dll respectively, and getting rid of the entire DLL redirection setup for good since we need to implement the symlink stuff anyway.

@Raffarti
Copy link
Contributor

Raffarti commented Feb 3, 2018

Should I get rid of the redirection stuff entirely or adapt it?

@doitsujin
Copy link
Owner

Honestly, I'd remove it entirely because no one is going to be using it when the symlink setup is the default option. And it should be the default option, since it's the only one that works on mainline/wine-vulkan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants