Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checking to build widget #17

Closed
agubler opened this issue Mar 20, 2018 · 1 comment
Closed

Add type checking to build widget #17

agubler opened this issue Mar 20, 2018 · 1 comment

Comments

@agubler
Copy link
Member

agubler commented Mar 20, 2018

Currently type checking is disabled for cli-build-widget as it uses too much memory when building multiple custom elements.

We should look to see if any existing plugins (for example fork-ts-checker-webpack-plugin) can provide us with the type checking needed without consuming too many system resources.

@agubler agubler added this to the rc.2 milestone Mar 20, 2018
@dylans dylans removed this from the rc.2 milestone Mar 28, 2018
@agubler
Copy link
Member Author

agubler commented Nov 22, 2019

This is done, the command does type check for both targets (lib and custom element)

@agubler agubler closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants