Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automagically update commands #49

Closed
rishson opened this issue Sep 23, 2016 · 9 comments
Closed

Automagically update commands #49

rishson opened this issue Sep 23, 2016 · 9 comments

Comments

@rishson
Copy link
Contributor

rishson commented Sep 23, 2016

Extends #11

We should display which commands can be updated (where a more recent version is available):

dojo version

You are currently running:

dojo-cli-build-webpack 0.23.121 (can be updated)
dojo-cli-test 0.3.22 (can be updated)
...

On dojo-cli 2.1.223

Run 'dojo update' to update all commands to the latest versions.
Run 'dojo update -h' to see all the update options.

We will need to provide dojo update alongside this feature.

@rishson rishson changed the title version command - advances version command - with update versions. Sep 23, 2016
@rishson
Copy link
Contributor Author

rishson commented Oct 10, 2016

dojo update should update all out of date commands
dojo update someCommand should update only the specified command.

@matt-gadd matt-gadd changed the title version command - with update versions. update command Oct 11, 2016
@rishson
Copy link
Contributor Author

rishson commented Nov 7, 2016

Implementation plan for --outdated:

Using david,
parse package.json
remove all non dojo-cli prefixed dev-deps.
pass to david
display dojo cli command modules that can be updated and show latest stable release no, e.g.

build (dojo-cli-build-webpack) 1.0.0 can be updated to 1.2.3

where 1.2.3 is the latest stable release.

The removal of non dojo-cli prefixed dev-deps is to speed up the check, and because to get david to ignore deps, you have to name the deps to ignore rather than passing a regex.

@rishson rishson self-assigned this Nov 7, 2016
@rishson
Copy link
Contributor Author

rishson commented Nov 7, 2016

After discussion with @agubler - deciding to put the version check under a flag - version -outdated.

@rishson
Copy link
Contributor Author

rishson commented Nov 7, 2016

Moving the version --outdated work to a separate issue. Refs #68

@rishson
Copy link
Contributor Author

rishson commented Dec 1, 2016

So david does not expose its update functionality in the lib, only via its cli.
The implementation will have to do this itself:

npm.load(...);
npm.commands.install(..)

@agubler
Copy link
Member

agubler commented Dec 2, 2016

@Rishon wouldn't we just suggest that people use npm update --dev --save?

@rishson
Copy link
Contributor Author

rishson commented Dec 2, 2016

For now, I think just some text that says that is fine (but isn't it npm update --save - cus they may have installed commands as globals?)

@agubler
Copy link
Member

agubler commented Dec 2, 2016

it would be -g for global, --dev is so that it does devDepdencies as well.

@rishson
Copy link
Contributor Author

rishson commented Dec 2, 2016

Yeah - its not worth listing the permutations of flags to the user (global, dev-dep). Probably best to just say These commands can be updated with 'npm update' or similar.

Sidenote: npm update will downgrade deps that are passed latest - good to know 😕

@dylans dylans added this to the 2016.12 milestone Dec 5, 2016
@dylans dylans modified the milestones: 2017.01, 2016.12 Dec 21, 2016
@dylans dylans modified the milestones: 2017.01, 2017.02 Jan 31, 2017
@dylans dylans modified the milestones: 2017.03, 2017.02 Feb 19, 2017
@dylans dylans modified the milestones: 2017.04, 2017.03 Mar 27, 2017
@dylans dylans removed this from the 2017.04 milestone Apr 29, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@dylans dylans modified the milestones: 2017.07, 2017.08 Jul 29, 2017
@kitsonk kitsonk changed the title update command Automagically update commands Jul 31, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@kitsonk kitsonk added rc and removed beta3 labels Oct 9, 2017
@kitsonk kitsonk modified the milestones: 2017.09, 2017.12 Oct 9, 2017
@agubler agubler removed the rc label Jan 4, 2018
@dylans dylans modified the milestones: 2017.12, 2018.01 Jan 11, 2018
@dylans dylans modified the milestones: 2018.01, 2018.02 Feb 7, 2018
@dylans dylans removed this from the 2018.02 milestone Mar 1, 2018
@agubler agubler closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants