Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Bubbling and Cancelling of events with Evented #67

Closed
kitsonk opened this issue Sep 29, 2016 · 0 comments
Closed

Bubbling and Cancelling of events with Evented #67

kitsonk opened this issue Sep 29, 2016 · 0 comments

Comments

@kitsonk
Copy link
Member

kitsonk commented Sep 29, 2016

Enhancement

We had discussed if Evented would have built in functionality for bubbling and cancelling (see: dojo/core#78).

We have found use cases where cancelling events is useful (see: createStateful, createCloseableMixin, and createFormFieldMixin).

We also have identified a use case for bubbling where when dealing with widgets asynchronously that emit events, it is difficult to "capture" that instances easily, making it difficult to instrument your code for dealing with errors, where if the event bubbled, in the widget's case, you could quite easily listen on the projector for errors.

I had initially been resistant to over complicate Evented until we had valid use cases, but it is clear that both of those use cases should be supportable in the base class.

@kitsonk kitsonk added this to the 2016.10 milestone Sep 29, 2016
@kitsonk kitsonk changed the title Bubbling of events Bubbling and Cancelling of events with Evented Sep 29, 2016
@dylans dylans modified the milestones: 2016.11, 2016.10 Oct 31, 2016
@dylans dylans modified the milestones: 2016.11, 2016.12 Dec 5, 2016
@dylans dylans modified the milestones: 2017.01, 2016.12 Dec 21, 2016
@eheasley eheasley modified the milestones: 2017.02, 2017.01 Jan 24, 2017
@dylans dylans modified the milestones: 2017.02, 2017.03 Mar 1, 2017
@dylans dylans modified the milestones: 2017.04, 2017.03 Mar 25, 2017
@dylans dylans modified the milestones: 2017.04, 2017.05 Apr 7, 2017
@dylans dylans modified the milestones: 2017.05, 2017.06 May 5, 2017
@dylans dylans removed this from the 2017.05 milestone May 5, 2017
@dylans dylans modified the milestones: 2017.06, long-grass Jun 12, 2017
@kitsonk kitsonk closed this as completed Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants