Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

loader.d.ts missing from dist #209

Closed
novemberborn opened this issue Oct 11, 2016 · 5 comments
Closed

loader.d.ts missing from dist #209

novemberborn opened this issue Oct 11, 2016 · 5 comments

Comments

@novemberborn
Copy link
Contributor

Noticed this when building dojo/app#74:

Running "ts:dev" (ts) task
Compiling...
Using tsc v2.0.3
node_modules/dojo-core/load.d.ts(2,25): error TS2307: Cannot find module './loader'.

It is indeed missing in my node_modules/dojo-core folder.

Using 2.0.0-alpha.15.

@matt-gadd
Copy link
Contributor

matt-gadd commented Oct 11, 2016

@novemberborn tsc won't emit it in its output as it has no implementation. @kitsonk should we move the loader interface to dojo/interfaces?

@agubler
Copy link
Member

agubler commented Oct 11, 2016

Previously with these we have just made them .ts files and then the interface is created when declaration is turned on

@kitsonk
Copy link
Member

kitsonk commented Oct 11, 2016

Yes, though that was sort of hacky, in the sense we should copy any .d.ts from the source directory, though it is true this interface should be moved. Opened dojo/interfaces#5 for that, but should we have an issue on the copying of declaration files from /src/?

@mwistrand
Copy link

@kitsonk Yes, I agree it would be helpful if .d.ts files were copied from the src/ directory. I'll open an issue on dojo/grunt-dojo2.

@kitsonk
Copy link
Member

kitsonk commented Oct 21, 2016

Given that, let's close this then, since we have the two issues that came out of this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants