Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

IE9 posting coverage... #94

Closed
kitsonk opened this issue Dec 7, 2015 · 3 comments
Closed

IE9 posting coverage... #94

kitsonk opened this issue Dec 7, 2015 · 3 comments
Assignees
Milestone

Comments

@kitsonk
Copy link
Member

kitsonk commented Dec 7, 2015

For some reason we seem to be having issues with IE9 at the end of its test in CI. A quick google appears to be related to throwing an error when trying to introspect XMLHttpRequest at the wrong time. I am not sure if it is something in dojo/core or something in Intern that is causing the challenge.

@mwistrand
Copy link

This is an issue with request/xhr. request.abort() is called when the request times out, but the onreadystatechange callback is still fired. A guard can be added when the request is aborted to prevent this error in IE9, although I'm having a hard time coming up with a unit test for this that doesn't unnecessarily expose implementation innards.

@kitsonk
Copy link
Member Author

kitsonk commented Dec 14, 2015

While I agree about the unit tests at the moment, it brings up a question. Should there be an exposed public API around abort() for request? @bryanforbes any thoughts?

@kitsonk
Copy link
Member Author

kitsonk commented Dec 14, 2015

Nevermind, I am talking rubbish... DOH! Ignore me.

@dylans dylans added this to the Milestone 2 milestone Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants