Update html.js (#18703)

[willgriffin]

currently if a number is passed as the second argument to the dojo.html.set method it results in a "Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'" error and as i result i no longer have any hair left as i've ripped it all out. If javascript is automatically going to determine the variable type it stands to reason that numbers should be synonymous with strings in this instance

[wkeese]

I'm conceptually OK with that change but the two objections I have are:

1. There are many methods in that file that (like set()) are documented to take a string but not a number. Why just fix set()?
2. The fix should have a unit test.

[willgriffin]

Is that better? I wasn't sure whether i should add Number as a allowable type so i just left it as is.

[wkeese]

Seems reasonable to me.

[dylans]

I'm fine with this PR, but I don't see a CLA on file for @willgriffin . Please see https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md and http://dojofoundation.org/about/claForm in particular, and then we can land this patch. Unless this is covered under a company CLA, and in that case, just let us know.

[dylans]

@willgriffin please see my previous note about having a CLA on file.

[willgriffin]

Hey, Sorry about missing your message the first time around.. I've
completed the CLA now.

On Fri, Sep 11, 2015 at 8:19 AM, Dylan Schiemann notifications@github.com
wrote:

@willgriffin https://github.com/willgriffin please see my previous note
about having a CLA on file.

—
Reply to this email directly or view it on GitHub
#152 (comment).

[dylans]

Closed via 1b18e24. Given that it is a subtle change in behavior, I'm not going to backport unless people think we should. Thanks for your first commit to Dojo @willgriffin !