Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction in docScroll #360

Merged
merged 1 commit into from Sep 4, 2019
Merged

Correction in docScroll #360

merged 1 commit into from Sep 4, 2019

Conversation

@jojow950i
Copy link
Contributor

jojow950i commented Aug 22, 2019

Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.

Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Aug 22, 2019

CLA assistant check
All committers have signed the CLA.

@wkeese

This comment has been minimized.

Copy link
Member

wkeese commented Aug 23, 2019

Makes sense to me, looks like you are essentially fixing a "typo" in the old code.

@dylans
dylans approved these changes Sep 4, 2019
@dylans dylans merged commit 88c915f into dojo:master Sep 4, 2019
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
dylans added a commit that referenced this pull request Sep 4, 2019
Variable "node" leverages doc given by window instead of the one given as a parameter. Noticed when putting a popup into an iframe where the content of the iframe has quite some height.
(cherry picked from commit 88c915f)
@dylans

This comment has been minimized.

Copy link
Member

dylans commented Sep 4, 2019

Backported as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.