Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Element.matches if available #64

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@foolip
Copy link
Contributor

commented Mar 8, 2014

Spec:
http://dom.spec.whatwg.org/#dom-element-matches

Support in Chromium:
https://code.google.com/p/chromium/issues/detail?id=326652

Element.matchesSelector was never standardized and it is not available
in the most recent versions of Blink, Gecko, Presto, Trident or WebKit.

Remove the trailing comment since it had become stale. Opera 12.16
(Presto) did have oMatchesSelector and since Opera 14 (Blink) it has
webkitMatchesSelector instead.

@foolip

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2014

The discussion in a similar pull request for Sizzle may be of interest: jquery/sizzle#251

Use Element.matches if available
Spec:
http://dom.spec.whatwg.org/#dom-element-matches

Support in Chromium:
https://code.google.com/p/chromium/issues/detail?id=326652

Element.matchesSelector was never standardized and it is not available
in the most recent versions of Blink, Gecko, Presto, Trident or WebKit.

Remove the trailing comment since it had become stale. Opera 12.16
(Presto) did have oMatchesSelector and since Opera 14 (Blink) it has
webkitMatchesSelector instead.
@dylans

This comment has been minimized.

Copy link
Member

commented Apr 9, 2014

Normally I would ask for a CLA (http://dojofoundation.org/about/claForm) , but it's a trivial 1 line patch.

@dylans

This comment has been minimized.

Copy link
Member

commented Apr 9, 2014

@dylans dylans added this to the 1.10 milestone Apr 9, 2014

@kriszyp

This comment has been minimized.

Copy link
Member

commented Apr 10, 2014

Committed in e5f099e

@kriszyp kriszyp closed this Apr 10, 2014

@foolip

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2014

I actually signed the CLA when I opened this pull request, just in case.

@foolip foolip deleted the foolip:matches-unprefixed branch Apr 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.