Use Element.matches if available #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The discussion in a similar pull request for Sizzle may be of interest: jquery/sizzle#251 |
Spec: http://dom.spec.whatwg.org/#dom-element-matches Support in Chromium: https://code.google.com/p/chromium/issues/detail?id=326652 Element.matchesSelector was never standardized and it is not available in the most recent versions of Blink, Gecko, Presto, Trident or WebKit. Remove the trailing comment since it had become stale. Opera 12.16 (Presto) did have oMatchesSelector and since Opera 14 (Blink) it has webkitMatchesSelector instead.
|
Normally I would ask for a CLA (http://dojofoundation.org/about/claForm) , but it's a trivial 1 line patch. |
|
Added https://bugs.dojotoolkit.org/ticket/17855 to track this. |
|
Committed in e5f099e |
|
I actually signed the CLA when I opened this pull request, just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec:
http://dom.spec.whatwg.org/#dom-element-matches
Support in Chromium:
https://code.google.com/p/chromium/issues/detail?id=326652
Element.matchesSelector was never standardized and it is not available
in the most recent versions of Blink, Gecko, Presto, Trident or WebKit.
Remove the trailing comment since it had become stale. Opera 12.16
(Presto) did have oMatchesSelector and since Opera 14 (Blink) it has
webkitMatchesSelector instead.