-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to typings #27
Comments
Actually, we need to do it, since DTS and DefinitelyTyped have been officially deprecated by the TypeScript team in lieu of typings/typings. |
Worth noting this may be required as part of the transition for |
* Integrate grunt-dojo2 * Realign distribution build (refs: dojo/meta#18) * Migrates to typings/typings, except for /tests (refs: dojo/meta#27) * Add prepublish and test to package.json
* Integrate grunt-dojo2 * Realign distribution build (refs: dojo/meta#18) * Migrates to typings/typings, except for /tests (refs: dojo/meta#27) * Add prepublish and test to package.json
@kitsonk Could you take a look at https://github.com/vansimke/core/tree/meta_issue_27 and let me know what you think? Everything seems to work except from |
@vansimke, thank you! It is fine to leave it without Couple notes though:
|
A consolidated diff if anyone else wants to have a look. |
* Integrate grunt-dojo2 * Realign distribution build (refs: dojo/meta#18) * Migrates to typings/typings, except for /tests (refs: dojo/meta#27) * Add prepublish and test to package.json
Yeah, I was only trying to get a straw man out there. I'll clean things up and then submit a PR for it. |
I've made some updates to my fork, but I'm not happy about where things are at. Currently, due to the conflicts between the different typings (which is exacerbated by including symbol-shim), If we're okay with this direction, then I can submit a PR to dojo/typings to add the new typings that I need to centralize the non-published type definitions and then update this branch to point to those definitions. |
@vansimke sorry to send you on a fools errand. I am in the process of adapting dojo-core, because we need to get a new release out for some downstream development. I apologise too much of this is in my head at the moment to be able to effectively get someone else to be able to address it, but I suspect it will just be easier for everyone if I just finish it off. |
* Integrate grunt-dojo2 * Realign distribution build (refs: dojo/meta#18) * Migrates to typings/typings, except for /tests (refs: dojo/meta#27) * Add prepublish and test to package.json
* Integrate grunt-dojo2 * Realign distribution build (refs: dojo/meta#18) * Migrates to typings/typings (refs: dojo/meta#27) * Add prepublish and test to package.json * Other packaging updates
* Integrate grunt-dojo2 * Realign distribution build (refs: dojo/meta#18) * Migrates to typings/typings, except for /tests (refs: dojo/meta#27) * Add prepublish and test to package.json
Actually we have completed this work, though we now need to migrate to |
We should consider migrating to typings/typings for type management for Dojo 2. It solves some of the challenges that TSD and the other sort of issues that can occur with complex type management and dependencies.
The text was updated successfully, but these errors were encountered: