Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Cannot add children to a Custom Element after creation #531

Closed
matt-gadd opened this issue May 22, 2017 · 4 comments
Closed

Cannot add children to a Custom Element after creation #531

matt-gadd opened this issue May 22, 2017 · 4 comments

Comments

@matt-gadd
Copy link
Contributor

Enhancement
If you create a custom element then add children post creation, they are not consumed into the parent. We can achieve this using a MutationObserver to watch for child nodes.

@kitsonk
Copy link
Member

kitsonk commented May 22, 2017

That would give us the changes, but another consideration is what to do with the DOM after that. Re-using DOM after the projector is created would be tricky I suspect, so it would be easier to detach those children from the DOM, generate the virtual DOM nodes necessary and then invalidate.

@matt-gadd
Copy link
Contributor Author

@kitsonk we already do those things via the DomWrapper. basically we just need to take the children nodes, wrap them and set them as children (we already do this at the initialisation phase)

@dylans dylans added this to the 2017.05 milestone May 22, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@kitsonk
Copy link
Member

kitsonk commented Jul 28, 2017

This is flagged as expedited but hasn't been actioned. Is this still required, and if so, when?

@dylans dylans modified the milestones: 2017.07, 2017.08 Aug 4, 2017
@kitsonk kitsonk added beta4 and removed expedited labels Aug 29, 2017
@kitsonk kitsonk modified the milestones: 2017.10, 2017.08 Aug 29, 2017
@kitsonk
Copy link
Member

kitsonk commented Oct 10, 2017

Need to do something with this or close it.

@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@maier49 maier49 self-assigned this Nov 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants