This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Move logic in custom element initialization #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
Nov 6, 2017
There was a problem hiding this comment.
Looks good to me, but as requested @matt-gadd should review as well.
|
Looks like the custom element functional tests are failing on CI. |
matt-gadd
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
If I'm understanding the code correctly, the widget won't render until it's attached to the projector. That happens here, in the callback that gets called when the custom element is attached to the DOM. So until that point we don't need to worry about a
MutationObserver, because we can just capture the state of the element when it's attached and set the appropriate children at that time. This has the added benefit of letting things likereplaceChildandinsertBeforework as expected, without a lot of additional logic.If we want to be able to add children after the element is attached then we will probably need to track the elements we've seen and use a
MutationObserverto detect new children and create widgets for them. That should probably be a separate PR though.Resolves #531