✨ Allow for specifying the S3 Storage Class #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 14, 2020 02:28
Requires that dokku/docker-s3backup#12 be merged
| rm -f "$SERVICE_BACKUP_ROOT/AWS_SECRET_ACCESS_KEY" | ||
| rm -f "$SERVICE_BACKUP_ROOT/AWS_DEFAULT_REGION" | ||
| rm -f "$SERVICE_BACKUP_ROOT/AWS_SIGNATURE_VERSION" | ||
| rm -f "$SERVICE_BACKUP_ROOT/ENDPOINT_URL" |
There was a problem hiding this comment.
Because the auth command is no longer the only one using that directory, leaving it the way it was would also delete the S3_STORAGE_CLASS.
| @@ -226,7 +231,7 @@ service_backup_auth() { | |||
| declare SERVICE="$1" AWS_ACCESS_KEY_ID="$2" AWS_SECRET_ACCESS_KEY="$3" AWS_DEFAULT_REGION="$4" AWS_SIGNATURE_VERSION="$5" ENDPOINT_URL="$6" | |||
| local SERVICE_BACKUP_ROOT="$PLUGIN_DATA_ROOT/$SERVICE/backup" | |||
|
|
|||
| mkdir "$SERVICE_BACKUP_ROOT" | |||
| mkdir -p "$SERVICE_BACKUP_ROOT" | |||
There was a problem hiding this comment.
Otherwise it will fail upon trying to create the dir if it already existed
README.md
Outdated
| @@ -21,6 +21,7 @@ postgres:app-links <app> # list all postgres service l | |||
| postgres:backup <service> <bucket-name> [--use-iam] # creates a backup of the postgres service to an existing s3 bucket | |||
| postgres:backup-auth <service> <aws-access-key-id> <aws-secret-access-key> <aws-default-region> <aws-signature-version> <endpoint-url> # sets up authentication for backups on the postgres service | |||
| postgres:backup-deauth <service> # removes backup authentication for the postgres service | |||
| postgres:backup-s3class <service> <s> <-storage-class> # sets the S3 storage class to be used for backups on the postgres service | |||
There was a problem hiding this comment.
Can you manually regenerate the readme via make README.md?
There was a problem hiding this comment.
That's the way it generates, I can fix the output but idk if there's an issue with the parsing or my subcommand.
common-functions
Outdated
| local SERVICE_BACKUP_ROOT="$PLUGIN_DATA_ROOT/$SERVICE/backup/" | ||
|
|
||
| mkdir -p "$SERVICE_BACKUP_ROOT" | ||
| echo "$S3_STORAGE_CLASS" >"$SERVICE_BACKUP_ROOT/S3_STORAGE_CLASS" |
There was a problem hiding this comment.
I really need to transfer all of this to the new properties system...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires that dokku/docker-s3backup#12 be merged