feat: add a test to prove that tls breaks app renames

dokku · Jul 28, 2018 · df834f4 · df834f4
1 parent e8265ac
commit df834f4
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 13 deletions.
diff --git a/tests/unit/10_apps.bats b/tests/unit/10_apps.bats
@@ -113,6 +113,19 @@ teardown () {
   assert_success
 }
 
+@test "(apps) apps:rename with tls" {
+  setup_test_tls
+  deploy_app
+  run bash -c "dokku apps:rename $TEST_APP great-test-name"
+  echo "output: "$output
+  echo "status: "$status
+  assert_success
+  run bash -c "dokku --force apps:destroy great-test-name"
+  echo "output: "$output
+  echo "status: "$status
+  assert_success
+}
+
 @test "(apps) apps:clone" {
   deploy_app
   run bash -c "dokku apps:clone $TEST_APP great-test-name"
@@ -213,4 +226,4 @@ teardown () {
   assert_output "false"
 
   destroy_app
-}
+}
diff --git a/tests/unit/30_core_1.bats b/tests/unit/30_core_1.bats
@@ -24,12 +24,6 @@ assert_urls() {
   assert_output < <(tr ' ' '\n' <<< "${urls}")
 }
 
-build_nginx_config() {
-  # simulate nginx post-deploy
-  dokku domains:setup $TEST_APP
-  dokku nginx:build-config $TEST_APP
-}
-
 @test "(core) remove exited containers" {
   deploy_app
 

diff --git a/tests/unit/40_core_2.bats b/tests/unit/40_core_2.bats
@@ -31,12 +31,6 @@ assert_url() {
   assert_output "${url}"
 }
 
-build_nginx_config() {
-  # simulate nginx post-deploy
-  dokku domains:setup $TEST_APP
-  dokku nginx:build-config $TEST_APP
-}
-
 @test "(core) run (with --options)" {
   deploy_app
   run /bin/bash -c "dokku --force --quiet run $TEST_APP node --version"

diff --git a/tests/unit/test_helper.bash b/tests/unit/test_helper.bash
@@ -372,3 +372,9 @@ cat<<EOF > "$APP_REPO_DIR/nginx.conf.sigil"
 some lame nginx config
 EOF
 }
+
+build_nginx_config() {
+  # simulate nginx post-deploy
+  dokku domains:setup "$TEST_APP"
+  dokku nginx:build-config "$TEST_APP"
+}