Correct comments on network triggers #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix comments of `func main()` closes dokku#2946
josegonzalez
approved these changes
Nov 3, 2017
josegonzalez
changed the title
josegonzalez
added a commit
that referenced
this pull request
Dec 12, 2017
# History ## 0.11.0 ### Bug Fixes - #2998: @josegonzalez Fix issues in release process - #2993: @josegonzalez Add config_all alias for plugin usage - #2972: @buckle2000 Correct typo in docker-options:remove error output - #2964: @znz Remove unused variable - #2967: @znz Fix indentation in test file - #2963: @znz Correct typos in config plugin and remove potential infinite recursion issue - #2951: @josegonzalez Handle case where the app directory is a symlink - #2939: @znz Remove unnecessary lines - #2945: @znz Fix network plugin version - #2937: @michaelshobbs Strip restart flag from app_user_pre_deploy_trigger - #2931: @josegonzalez Upgrade git package for CI - #2928: @silverfix Do not overwrite the VHOST file during installation if it exists - #2926: @vtavernier Remove leading forward slash from app name in git-upload-pack ### New Features - #2985: @bitmand Build a custom dhparam file once for nginx and include it as default - #2974: @josegonzalez Upgrade to herokuish 0.3.33 - #2973: @josegonzalez Allow usage of git 2.13.0+ by unsetting GIT_QUARANTINE_PATH during git worktree usage - #2971: @miraculixx Add support for older virtualbox versions in official Dokku Vagrantfile - #2966: @znz Simplify internal config functions to reduce duplication - #2751: @alexquick Move config plugin to golang - #2938: @michaelshobbs Upgrade to golang 1.9.1 - #2736: @josegonzalez Implement Network Plugin - #2929: @michaelshobbs Add codacy config and coverage targets ### Documentation - #2935: @jcrben Document how to make herokuish optional during the bootstrap installation - #2982: @agorf Correct typo in user management docs - #2981: @agorf Correct typos in process management docs - #2969: @znz Correct comments on network triggers - #2965: @znz Remove spaces from config subcommand help output to mirror help output of other subcommands - #2954: @mrname Add vernemq community datastore plugin to docs - #2944: @axilleas Fix syntax typo in debian installation docs - #2932: @znz Update code comment to match documentation - #2933: @znz Fix version number for network binding documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix comments of
func main()closes #2946