Remove all uses of proxy_set_header Connection "upgrade" #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proxy_set_header Connection "upgrade"
stickler-ci
reviewed
Jul 13, 2019
|
Thanks for the pull request! |
josegonzalez
added a commit
that referenced
this pull request
Aug 7, 2019
# History ## 0.18.0 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.18.0/bootstrap.sh sudo DOKKU_TAG=v0.18.0 bash bootstrap.sh ``` ### Bug Fixes - #3627: @josegonzalez Make image removal synchronous - #3618: @josegonzalez Ensure the dokku-retire timer is properly installed - #3614: @alexquick Validate args for config:set and config:unset - #3605: @josegonzalez Handle case where there are empty newlines in the authorized_keys file - #3603: @josegonzalez Drop extra % sign in common.LogVerboseQuiet - #3597: @josegonzalez Allow default trace function to work ### New Features - #3628: @josegonzalez Handle file copying in a secure and reliable fashion - #3630: @josegonzalez Fix issue where push warning on bad branch was skipped - #3629: @josegonzalez Avoid calling the user-auth trigger where possible - #3626: @josegonzalez Builder plugins - #3599: @josegonzalez Scope docker-cleanup to specific app - #3589: @michaelshobbs Allow running Dokku in Docker - #3607: @josegonzalez Purge cache using herokuish image - #3602: @alexymik Create a 502 error page to automatically refresh if backend status changes - #3600: @josegonzalez Refactor IsImageHerokuishBased to match shell version ### Documentation - #3625: @josegonzalez Remove old reference to SPONSORS.md - #3619: @josegonzalez Cleanup plugin creation docs - #3612: @jayjun Improve testing docs - #3613: @Lyelt Remove all uses of proxy_set_header Connection "upgrade" - #3596: @josegonzalez Add missing hooks to events plugin and plugin triggers docs ### Tests - #3610: @jayjun Correct Bats path in single tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all uses of proxy_set_header Connection "upgrade"
Setting this header to "upgrade" was fixed in the nginx.conf.sigil file in this commit. It should be fixed in the remaining docs/tests where it was still being set.