Add environment variable support to CNB-based containers #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is necessary for us to be able to inject env vars into the call.
They are not baked into the image like they are for herokuish, so we need to manually set them via --env. Additionally, due to newline constraints in docker, we need to use `--env=key` format to correctly pull the values into place.
stickler-ci
reviewed
Feb 11, 2021
josegonzalez
force-pushed
the
cnb-env-vars
branch
from
a6a25ed
to
1568fc7
Compare
josegonzalez
pushed a commit
that referenced
this pull request
Feb 11, 2021
# History ## 0.23.3 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.23.3/bootstrap.sh sudo DOKKU_TAG=v0.23.3 bash bootstrap.sh ``` ### Bug Fixes - #4397: @josegonzalez Correctly handle environment variables in deployment tasks for Cloud Native Buildpacks - #4394: @josegonzalez Swap order of arguments on config-get call ### New Features - #4395: @josegonzalez Add environment variable support to CNB-based containers ### Refactors - #4393: @josegonzalez Use docker-image-labeler in cnb builder-build trigger ### Documentation - #4396: @nerg4l Invalid link to Herokuish Buildpack Deployment in Cloud Native Buildpacks ### Tests - #4390: @josegonzalez Run tests faster by not cloning the buildpack each time ### Other - #4389: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 188 to 189 in /tests/apps/php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.