Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid link to Herokuish Buildpack Deployment in Cloud Native Buildpacks #4396

Conversation

nerg4l
Copy link
Contributor

@nerg4l nerg4l commented Feb 11, 2021

The documentation of Cloud Native Buildpacks contains a link to Herokuish Buildpack Deployment. The link redirects to an invalid url and causes 404.

http://dokku.viewdocs.io/dokku/deployment/methods/cloud-native-buildpacks/

[ci skip]
@josegonzalez josegonzalez merged commit e07befb into dokku:master Feb 11, 2021
@josegonzalez
Copy link
Member

Thanks for the pull request.

josegonzalez pushed a commit that referenced this pull request Feb 11, 2021
# History

## 0.23.3

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.23.3/bootstrap.sh
sudo DOKKU_TAG=v0.23.3 bash bootstrap.sh
```

### Bug Fixes

- #4397: @josegonzalez Correctly handle environment variables in deployment tasks for Cloud Native Buildpacks
- #4394: @josegonzalez Swap order of arguments on config-get call

### New Features

- #4395: @josegonzalez Add environment variable support to CNB-based containers

### Refactors

- #4393: @josegonzalez Use docker-image-labeler in cnb builder-build trigger

### Documentation

- #4396: @nerg4l Invalid link to Herokuish Buildpack Deployment in Cloud Native Buildpacks

### Tests

- #4390: @josegonzalez Run tests faster by not cloning the buildpack each time

### Other

- #4389: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 188 to 189 in /tests/apps/php
@nerg4l nerg4l deleted the documentation-patch-cloud-native-buildpacks-link branch March 22, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants