Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set the plugin repository name when installing in a docker-based dokku install #6009

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

josegonzalez
Copy link
Member

No description provided.

@iphoting
Copy link
Contributor

iphoting commented Jul 8, 2023

Thank you! Perhaps consider a test-case for this so that CI will pickup any regressions. 😀

@josegonzalez
Copy link
Member Author

@iphoting is that something you'd be willing to contribute?

@iphoting
Copy link
Contributor

iphoting commented Jul 8, 2023

@josegonzalez is there already a testing framework set-up for docker-based dokku installs? I can't seem to figure out if there already is from a quick look over the tests folder.

@josegonzalez
Copy link
Member Author

The docker-based setup is tested via the docker-deploy-tests job in ci.yml.

@josegonzalez josegonzalez merged commit 34d5a96 into master Jul 9, 2023
91 checks passed
@josegonzalez josegonzalez deleted the fix-plugin-install branch July 9, 2023 02:35
github-actions bot pushed a commit that referenced this pull request Jul 9, 2023
# History

## 0.30.9

Install/update via the bootstrap script:

```shell
wget -NP . https://dokku.com/install/v0.30.9/bootstrap.sh
sudo DOKKU_TAG=v0.30.9 bash bootstrap.sh
```

### Bug Fixes

- #6009: @josegonzalez Properly set the plugin repository name when installing in a docker-based dokku install
- #5999: @caplod Fix http to https redirect in traefik

### Documentation

- #6006: @josegonzalez Clarify how to specify the contents of an ssh key for dokku
- #5998: @kleutzinger Fix typo in scheduled cron task documentation
- #5984: @josegonzalez Unify all Procfile-handling documentation under the process management docs
- #5982: @josegonzalez Update docs to mention that files are extracted from source where source code is available

### Dependencies

- #6008: @dependabot[bot] chore(deps): bump click from 8.1.3 to 8.1.4 in /docs/_build
- #6003: @dependabot[bot] chore(deps): bump django from 4.1.9 to 4.1.10 in /tests/apps/dockerfile-release
- #6005: @dependabot[bot] chore(deps): bump golang.org/x/net from 0.11.0 to 0.12.0 in /tests/apps/gogrpc
- #6000: @dependabot[bot] chore(deps): bump mkdocs-material from 9.1.17 to 9.1.18 in /docs/_build
@iphoting
Copy link
Contributor

iphoting commented Jul 9, 2023

I couldn't figure out enhancing the test framework to test this… except by adding an additional container deployment step, with a plugin-list injected to /var/lib/dokku. Really ugly.

That said, I quickly tested the revised code:

$ head -1 plugin-list 
redis: https://github.com/iphoting/dokku-redis.git
$ head -1 plugin-list | cut -d':' -f2
 https

It still broken. I think the correct invocation should be:
| cut -d':' -f2-

$ head -1 plugin-list | cut -d':' -f2-
 https://github.com/iphoting/dokku-redis.git

@josegonzalez
Copy link
Member Author

I think I forgot to change that cut to one on a space character (or awk print $2). Mind making a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants