Use image pull secrets instead of registries.yaml to reference private repositories when deploying via k3s #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rivate repositories While this will now more or less require a local docker login - which can be overridden by setting the image-pull-secrets property - this ensures every deploy has a valid context. One annoying thing is that the secret is per-app vs global, meaning that if the secret must be rotated, all apps need to be redeployed. A future change can fix that by deploying a global secret, or if folks really desire, this can be done by setting the image-pull-secrets property on the app/globally.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
# History ## 0.33.6 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.33.6/bootstrap.sh sudo DOKKU_TAG=v0.33.6 bash bootstrap.sh ``` ### Bug Fixes - #6589: @josegonzalez Use image pull secrets instead of registries.yaml to reference private repositories when deploying via k3s - #6581: @josegonzalez Fix issues in tls handling when deploying via k3s - #6582: @josegonzalez Correctly handle extra whitespace in scale file contents - #6390: @renweibo Prefer systemctl over sv when both exist while restarting nginx - #6579: @josegonzalez Ensure k3s can be installed with taints ### New Features - #6585: @josegonzalez Add more context to errors in fetching cron entries - #6583: @josegonzalez Add WithContext functions for all subprocess-related code ### Refactors - #6584: @josegonzalez Use new CallExecCommand when checking to see how help is being called ### Dependencies - #6586: @dependabot[bot] chore(deps): bump mvdan.cc/sh/v3 from 3.7.0 to 3.8.0 in /plugins/cron - #6587: @dependabot[bot] chore(deps): bump mkdocs-material from 9.5.8 to 9.5.9 in /docs/_build - #6381: @dependabot[bot] chore(deps): bump actions/upload-artifact from 3 to 4 - #6578: @josegonzalez Bump go modules ### Other - #6576: @Tashows Allow creating a detached container with TTY enabled for attaching remote terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this will now more or less require a local docker login - which can be overridden by setting the image-pull-secrets property - this ensures every deploy has a valid context.
The original issue is that we needed to bounce k3s on every host after updating the registry file, which would basically mean downtime if handled incorrectly
One annoying thing is that the secret is per-app vs global, meaning that if the secret must be rotated, all apps need to be redeployed. A future change can fix that by deploying a global secret, or if folks really desire, this can be done by setting the image-pull-secrets property on the app/globally.