Always capture stdout/stderr when executing subprocesses #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is almost certainly the correct default for Dokku. While it's a BC break and might cause an increase in memory usage, the api is mostly internal and therefore this is safe to use.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
# History ## 0.33.7 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.33.7/bootstrap.sh sudo DOKKU_TAG=v0.33.7 bash bootstrap.sh ``` ### Bug Fixes - #6608: @josegonzalez Fix issue with setting k3s resource values and lower the initial default values - #6607: @josegonzalez Call sed in unbuffered form to ensure log output is streamed to stdout - #6600: @josegonzalez Use correct label key for worker nodes - #6593: @josegonzalez Remove extra trailing newline to fix govet issue ### New Features - #6595: @josegonzalez Add ability for users to specify alternative kubeconfig and kubecontext ### Refactors - #6594: @josegonzalez Remove all calls to common.NewShellCmd - #6592: @josegonzalez Remove all calls to common.NewShellCmdWithArgs - #6591: @josegonzalez Always capture stdout/stderr when executing subprocesses - #6590: @josegonzalez Remove all direct usage of go-sh outside of plugin trigger setup ### Dependencies - #6609: @dependabot[bot] chore(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 in /tests/apps/gogrpc - #6604: @dependabot[bot] chore(deps): bump mkdocs-material from 9.5.9 to 9.5.10 in /docs/_build - #6603: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 42.0.2 to 42.0.4 - #6601: @dependabot[bot] chore(deps): bump helm.sh/helm/v3 from 3.13.3 to 3.14.1 in /plugins/scheduler-k3s - #6596: @dependabot[bot] chore(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1 in /tests/apps/gogrpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost certainly the correct default for Dokku. While it's a BC break and might cause an increase in memory usage, the api is mostly internal and therefore this is safe to use.