Handle case where keda isn't installed properly #6677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If keda is not installed, warn the user that it isn't installed and ignore the rest. Ignoring the error here is fine as it gives the user context but doesn't block a deploy.
josegonzalez
force-pushed
the
wrap-missing-helm-chart
branch
from
70bda25
to
f289220
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
# History ## 0.33.9 Install/update via the bootstrap script: ```shell wget -NP . https://dokku.com/install/v0.33.9/bootstrap.sh sudo DOKKU_TAG=v0.33.9 bash bootstrap.sh ``` ### Bug Fixes - #6695: @josegonzalez Do not attempt to install both k3s and traefik - #6687: @josegonzalez Correct issue where ClusterTriggerAuthentication objects were filtered based on prefix - #6686: @josegonzalez Validate input for the autoscaling-auth:set command - #6678: @josegonzalez Handle case where most builders didn't detect amd64 images on arm64 - #6677: @josegonzalez Handle case where keda isn't installed properly - #6676: @josegonzalez Drop extra logging call from app-json plugin - #6674: @josegonzalez Remove systemd reverse dependency by dropping software-properties-common ### New Features - #6698: @josegonzalez Upgrade ingress-nginx - #6588: @taraszka Add extra tags to every image dokku push when push-extra-tags are set - #6680: @josegonzalez Wait until helm charts are installed before marking a deploy as failed or completed ### Documentation - #6699: @josegonzalez Add a placeholder migration guide for 0.33.0 - #6682: @josegonzalez Fix reference to formation key in autoscaling example ### Tests - #6696: @josegonzalez Run k3s tests with a specified server ip - #6679: @josegonzalez Split out k3s tests to speed up ci ### Dependencies - #6697: @dependabot[bot] chore(deps): bump timberio/vector from 0.36.0-debian to 0.36.1-debian in /plugins/logs - #6685: @dependabot[bot] chore(deps): bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 in /plugins/scheduler-k3s - #6692: @dependabot[bot] chore(deps): bump packaging from 23.2 to 24.0 in /docs/_build - #6693: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 42.0.7 to 42.1.0 - #6689: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 42.0.6 to 42.0.7 - #6683: @dependabot[bot] chore(deps): bump importlib-metadata from 7.0.1 to 7.0.2 in /docs/_build - #6684: @dependabot[bot] chore(deps): bump tj-actions/changed-files from 42.0.5 to 42.0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If keda is not installed, warn the user that it isn't installed and ignore the rest.
Ignoring the error here is fine as it gives the user context but doesn't block a deploy.