Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the plugn shell dev helper on linux #151

Merged
merged 1 commit into from
May 19, 2024

Conversation

killjoy1221
Copy link
Contributor

This automatically selects a file suffix on linux based on uname -m. I've also made lowercasing the output of uname to use the bashism ${X,,}.

There's room for Apple M2 if separate binaries ever need to be built for that.

@josegonzalez
Copy link
Member

I forget, where is this file ever used?

@killjoy1221
Copy link
Contributor Author

I don't think it's actually included in the final build. My understanding is it was a helper script during dev so we don't have to run ./build/linux/plugn, as that's basically what the script called via exec.

@josegonzalez josegonzalez merged commit b3e7e14 into dokku:main May 19, 2024
3 checks passed
@killjoy1221 killjoy1221 deleted the fix/shell-helper branch May 20, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants