Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Rename events related to video and screenshare #347

Closed
kubaau opened this issue Aug 4, 2023 · 1 comment
Closed

Rename events related to video and screenshare #347

kubaau opened this issue Aug 4, 2023 · 1 comment
Labels
code Needs changes to the plugin code docs Needs documentation update enhancement New feature or request samples Changes to sample plugin content wontfix This will not be worked on
Milestone
v1.3

Comments

@kubaau
Copy link
Contributor

kubaau commented Aug 4, 2023

Describe the feature request

The naming of the following events is confusing to some:

  • On Video Track Added/Removed
  • On Video Track Enabled/Disabled
  • On Video Enabled/Disabled
  • On Screenshare Started/Stopped

It would perhaps be better to rename them to:

  • On Remote Video Track Added/Removed
  • On Remote Video Track Enabled/Disabled
  • On Video Enabled/Disabled
  • On Screenshare Started/Stopped

or:

  • On Remote Video Track Added/Removed
  • On Remote Video Track Enabled/Disabled
  • On Local Video Track Video Added/Removed

or:
split On Video Track Added/Removed into:

  • On Video Track Added/Removed
  • On Screenshare Track Added/Removed

It may also be convenient to change the logic of track Added/Enabled events or possibly remove the track Enabled/Disabled events altogether.
@kubaau kubaau added docs Needs documentation update enhancement New feature or request samples Changes to sample plugin content code Needs changes to the plugin code labels Aug 4, 2023
@kubaau kubaau added this to the v1.2 milestone Aug 4, 2023
@kubaau kubaau self-assigned this Aug 4, 2023
@kubaau kubaau moved this to 🆕 New in comms-sdk-unreal Aug 4, 2023
@kubaau kubaau moved this from 🆕 New to 🏗 In progress in comms-sdk-unreal Aug 14, 2023
@kubaau kubaau modified the milestones: v1.2, v1.3 Aug 21, 2023
@kubaau kubaau linked a pull request Aug 25, 2023 that will close this issue
Event refactor #370
Closed
@kubaau kubaau moved this from 🏗 In progress to 🛑 Halted in comms-sdk-unreal Sep 1, 2023
@kubaau kubaau removed a link to a pull request Sep 11, 2023
Event refactor #370
Closed
@kubaau kubaau removed their assignment Sep 15, 2023
@kubaau
Copy link
Contributor Author

kubaau commented Sep 15, 2023

Work stopped. WIP available at https://github.com/DolbyIO/comms-sdk-unreal/tree/delegate_refactor

@kubaau kubaau added the wontfix This will not be worked on label Sep 15, 2023
@kubaau kubaau closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2023
@github-project-automation github-project-automation bot moved this from 🛑 Halted to ✅ Done in comms-sdk-unreal Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code Needs changes to the plugin code docs Needs documentation update enhancement New feature or request samples Changes to sample plugin content wontfix This will not be worked on
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
1 participant
@kubaau