OGL/VertexManager: Make vertex and index buffer names private

These are only ever read, but not written to outside of the VertexManager class.
dolphin-emu · Sep 2, 2017 · 1dc46d7 · 1dc46d7
1 parent 657195f
commit 1dc46d7
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/Source/Core/VideoBackends/OGL/NativeVertexFormat.cpp b/Source/Core/VideoBackends/OGL/NativeVertexFormat.cpp
@@ -60,8 +60,8 @@ GLVertexFormat::GLVertexFormat(const PortableVertexDeclaration& _vtx_decl)
   ProgramShaderCache::BindVertexFormat(this);
 
   // the element buffer is bound directly to the vao, so we must it set for every vao
-  glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, vm->m_index_buffers);
-  glBindBuffer(GL_ARRAY_BUFFER, vm->m_vertex_buffers);
+  glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, vm->GetIndexBufferName());
+  glBindBuffer(GL_ARRAY_BUFFER, vm->GetVertexBufferName());
 
   SetPointer(SHADER_POSITION_ATTRIB, vertex_stride, _vtx_decl.position);
 

diff --git a/Source/Core/VideoBackends/OGL/Render.cpp b/Source/Core/VideoBackends/OGL/Render.cpp
@@ -1796,7 +1796,7 @@ void Renderer::RestoreAPIState()
 
   ProgramShaderCache::BindLastVertexFormat();
   const VertexManager* const vm = static_cast<VertexManager*>(g_vertex_manager.get());
-  glBindBuffer(GL_ARRAY_BUFFER, vm->m_vertex_buffers);
+  glBindBuffer(GL_ARRAY_BUFFER, vm->GetVertexBufferName());
 
   OGLTexture::SetStage();
 }

diff --git a/Source/Core/VideoBackends/OGL/VertexManager.cpp b/Source/Core/VideoBackends/OGL/VertexManager.cpp
@@ -61,6 +61,16 @@ void VertexManager::DestroyDeviceObjects()
   s_indexBuffer.reset();
 }
 
+GLuint VertexManager::GetVertexBufferName() const
+{
+  return m_vertex_buffers;
+}
+
+GLuint VertexManager::GetIndexBufferName() const
+{
+  return m_index_buffers;
+}
+
 void VertexManager::PrepareDrawBuffers(u32 stride)
 {
   u32 vertex_data_size = IndexGenerator::GetNumVerts() * stride;

diff --git a/Source/Core/VideoBackends/OGL/VertexManager.h b/Source/Core/VideoBackends/OGL/VertexManager.h
@@ -37,9 +37,8 @@ class VertexManager : public VertexManagerBase
   void CreateDeviceObjects() override;
   void DestroyDeviceObjects() override;
 
-  // NativeVertexFormat use this
-  GLuint m_vertex_buffers;
-  GLuint m_index_buffers;
+  GLuint GetVertexBufferName() const;
+  GLuint GetIndexBufferName() const;
 
 protected:
   void ResetBuffer(u32 stride) override;
@@ -49,6 +48,9 @@ class VertexManager : public VertexManagerBase
   void vFlush() override;
   void PrepareDrawBuffers(u32 stride);
 
+  GLuint m_vertex_buffers;
+  GLuint m_index_buffers;
+
   // Alternative buffers in CPU memory for primatives we are going to discard.
   std::vector<u8> m_cpu_v_buffer;
   std::vector<u16> m_cpu_i_buffer;