Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiiSaveCrypted: migrate to Core/HW. #1002

Merged
merged 1 commit into from Sep 8, 2014

Conversation

waddlesplash
Copy link
Contributor

There's really no reason to have this in DolphinWX, as it does not use any DolphinWX code.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 6, 2014

please rebase

@waddlesplash
Copy link
Contributor Author

Yes, was broken by #1003. I'll get to it tomorrow, busy rest of today.

@waddlesplash
Copy link
Contributor Author

@shuffle2 done.

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 7, 2014

@dolphin-emu-bot rebuild

@shuffle2
Copy link
Contributor

shuffle2 commented Sep 7, 2014

Sorry I missed that you didn't update the filters:
https://github.com/waddlesplash/dolphin/blob/wx-fixup/Source/Core/DolphinWX/DolphinWX.vcxproj.filters#L90
https://github.com/waddlesplash/dolphin/blob/wx-fixup/Source/Core/DolphinWX/DolphinWX.vcxproj.filters#L216

filters are used by VS to organize the files and aren't part of the build system, which is why build still passes. The related lines just need to be migrated into Core.vcxproj.filters

@waddlesplash
Copy link
Contributor Author

@shuffle2 done.

There's really no reason to have this in DolphinWX, as it does
not use any DolphinWX code.
@lioncash
Copy link
Member

lioncash commented Sep 8, 2014

@dolphin-emu-bot rebuild

@waddlesplash
Copy link
Contributor Author

@lioncash build succeed, can this be merged?

lioncash added a commit that referenced this pull request Sep 8, 2014
WiiSaveCrypted: migrate to Core/HW.
@lioncash lioncash merged commit bf0c4a6 into dolphin-emu:master Sep 8, 2014
@waddlesplash waddlesplash deleted the wx-fixup branch September 8, 2014 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants