DSP LLE: Rename CMPAR to CMPAXH #10702
Merged
+349
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The old name implies that it works on the address registers (like
DAR/IAR/SUBARN/ADDARN), while the new name is consistent withTSTAXHandMULAXH. This PR also adds a test that coversCMPAXHandTSTAXH. This PR is intended to be merged before #10692.Note that
CMPARwasn't included in the manual until #10048 (specifically 211c2b5), but was described in some notes without giving it a name (on http://hitmen.c02.at/html/gc_tools.html for DSP Suite, look in the zip's gcdspsuite/doc/reverse.txt and reverse_new.txt):In the initial megacommit, it existed in the table as CMPAXH and as cmpar in the actual implementation:
dolphin/Source/Plugins/Plugin_DSP_LLE/Src/gdsp_opcodes.cpp
Lines 551 to 563 in 775dc8a
dolphin/Source/Plugins/Plugin_DSP_LLE/Src/opcodes.cpp
Line 146 in 775dc8a
In 472e673 it was renamed to CMPAR in the table, but also commented out due to a separate bug. That bug was fixed in 8b6b8b6. There was an additional mistake that was fixed in 4747cc7.