VideoBackends:Vulkan: Clean up submission thread using WorkQueueThread #11417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So over in #11473, I added Maybe WorkQueueThread would be a better solution for the submission thread, the resulting code is much cleaner and it already handles this. |
|
Interesting, I'll take a look. |
K0bin
force-pushed
the
vk-submit-thread-cleanup
branch
from
56d14f8
to
2afd114
Compare
|
I tried to port it over to WorkQueueThread but that doesn't work so far. |
phire
reviewed
Jan 29, 2023
K0bin
force-pushed
the
vk-submit-thread-cleanup
branch
from
2afd114
to
194ed49
Compare
|
I'll wait for #11548 to land. |
K0bin
force-pushed
the
vk-submit-thread-cleanup
branch
from
194ed49
to
4a149f7
Compare
K0bin
force-pushed
the
vk-submit-thread-cleanup
branch
from
4a149f7
to
6332506
Compare
K0bin
force-pushed
the
vk-submit-thread-cleanup
branch
from
6332506
to
c1be962
Compare
|
Rebased and ready for review. |
K0bin
changed the title
|
Much much simpler code. Thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I used
BlockingLoopfor the Vulkan queue submission thread isn't optimal and it can be streamlined by usingWorkQueueThread.