Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-globalize vulkan backend #11548

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

phire
Copy link
Member

@phire phire commented Feb 9, 2023

This PR is built on #11531. I've created a temporary PR on my repo for easier review before that's merged

Split out from my Async Present branch.

There are still a few references to globals within VideoCommon, but all internal globals are gone.

VideoBackendBase is now just the Video API abstraction.
VideoBase is the main context for all the common code in VideoCommon.
They were baking in the active config at boot.
Instead, use backend_info.bSupportsVSLinePointExpand
Only gcc complained about this
There are still a few references to globals within VideoCommon, but
all internal globals are gone.
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@AdmiralCurtiss
Copy link
Contributor

I assume you pinged me here because of the moving to System stuff I've been doing? I'm not very familiar with the rendering code, but this looks pretty reasonable to me.

@phire
Copy link
Member Author

phire commented Feb 11, 2023

Yeah, I pinged you because you were doing de-globalisation work elsewhere. Thanks for taking a look.

Copy link
Contributor

@K0bin K0bin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me but it's pretty much impossible properly review a massive PR like this one.

@iwubcode
Copy link
Contributor

I've been punting on this and focusing on #11531 but that still has some issues.

This one fails on fifoci .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants