-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-globalize vulkan backend #11548
base: master
Are you sure you want to change the base?
De-globalize vulkan backend #11548
Conversation
VideoBackendBase is now just the Video API abstraction. VideoBase is the main context for all the common code in VideoCommon.
They were baking in the active config at boot. Instead, use backend_info.bSupportsVSLinePointExpand
Only gcc complained about this
There are still a few references to globals within VideoCommon, but all internal globals are gone.
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
I assume you pinged me here because of the moving to System stuff I've been doing? I'm not very familiar with the rendering code, but this looks pretty reasonable to me. |
Yeah, I pinged you because you were doing de-globalisation work elsewhere. Thanks for taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me but it's pretty much impossible properly review a massive PR like this one.
I've been punting on this and focusing on #11531 but that still has some issues. This one fails on fifoci . |
This PR is built on #11531. I've created a temporary PR on my repo for easier review before that's merged
Split out from my Async Present branch.
There are still a few references to globals within VideoCommon, but all internal globals are gone.