Android: Add a button for accessing controller mappings #11605
Conversation
|
I like this change, but could we use a settings cog icon instead? I feel like that fits better for the large set of options you get in the next menu. Then we could use the three dot icon just for the advanced mapping dialog. What do you think? Edit - I'm also just noticing now, when you have a controller disabled, the button just does nothing. That's not great in its current state. Is there a way you could set that view to |
The settings GameCube Controller N and Wii Remote N (where N is a number) have two purposes: You can select what controller type you want to use, and also, when you select a controller type (even if you're selecting the one that already is selected), the mapping settings open. This second part is less discoverable than it ideally should be. I'm changing it so that there now is a button for opening the mapping settings instead.
Yes, using the settings icon sounds like a good idea. The three dots made it seem just a bit too insignificant. Undecided on whether we should still go with the three dots for the advanced mapping dialog or if we should make it more consistent, but that decision doesn't have to be made in this PR.
It would be possible, but it would be annoying to implement cleanly because the logic for which choices do anything is in a different part of the code base. Currently we're jumping through a good number of method calls when the button is pressed. I was kind of pushing the issue aside because I figured setting the controller type to None and then pressing the button would happen pretty rarely, but what do you think? |
JosJuice
force-pushed
the
android-mappings-button
branch
from
6030af5
to
8acc39c
Compare
You're probably right but it doesn't really feel right to just leave that alone |
|
I'll try to get it working then. |
It was a bit silly having four functions for effectively the same thing in all of SettingsFragmentView, SettingsFragment, SettingsActivityView, SettingsActivity, and SettingsActivityPresenter. With this change, we split on the four MenuTag types in SettingsActivityPresenter instead of in SettingsAdapter.
|
Done. |
Source/Android/app/src/main/res/layout-ldrtl/list_item_setting.xml
Outdated
Show resolved
Hide resolved
|
@t895 Done. But please check that I did it correctly, because GitHub didn't do a nice line-by-line formatting of your second diff for some reason. |
JosJuice
force-pushed
the
android-mappings-button
branch
from
77c30ad
to
3cf49ef
Compare
|
Oh sorry, I messed up a bit. Could you please add |
Also removed the make_sure_continuous_scan_enabled message. It doesn't make sense with the new UX.
JosJuice
force-pushed
the
android-mappings-button
branch
from
3cf49ef
to
96deb2d
Compare
|
Sure thing. |
The settings GameCube Controller N and Wii Remote N (where N is a number) have two purposes: You can select what controller type you want to use, and also, when you select a controller type (even if you're selecting the one that already is selected), the mapping settings open. This second part is less discoverable than it ideally should be. I'm changing it so that there now is a button for opening the mapping settings instead.