Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add a button for accessing controller mappings #11605

Merged
merged 3 commits into from Mar 2, 2023

Commits on Feb 27, 2023

  1. Android: Add a button for accessing controller mappings

    The settings GameCube Controller N and Wii Remote N (where N is a number)
    have two purposes: You can select what controller type you want to use,
    and also, when you select a controller type (even if you're selecting the
    one that already is selected), the mapping settings open. This second part
    is less discoverable than it ideally should be. I'm changing it so that
    there now is a button for opening the mapping settings instead.
    JosJuice committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    8acc39c View commit details
    Browse the repository at this point in the history
  2. Android: Refactor handleMenuTag

    It was a bit silly having four functions for effectively the same thing
    in all of SettingsFragmentView, SettingsFragment, SettingsActivityView,
    SettingsActivity, and SettingsActivityPresenter.
    
    With this change, we split on the four MenuTag types in
    SettingsActivityPresenter instead of in SettingsAdapter.
    JosJuice committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    b827b15 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Android: Hide controller mappings button when controller type is None

    Also removed the make_sure_continuous_scan_enabled message.
    It doesn't make sense with the new UX.
    JosJuice committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    96deb2d View commit details
    Browse the repository at this point in the history