VideoCommon: split cache entry creation into a separate function #11661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
rework_texture_cache
branch
from
8ef8409
to
01250d5
Compare
iwubcode
force-pushed
the
rework_texture_cache
branch
from
01250d5
to
8cf2935
Compare
iwubcode
force-pushed
the
rework_texture_cache
branch
2 times, most recently
from
a7ae7ea
to
93d4fff
Compare
2 tasks
|
Other than that this looks fine to me. It's kinda hard to tell whether the code still does the same thing after the refactor but I think it does, and it's definitely less convoluted than the old one. |
iwubcode
force-pushed
the
rework_texture_cache
branch
from
93d4fff
to
7efa496
Compare
AdmiralCurtiss
approved these changes
Apr 8, 2023
lioncash
reviewed
Apr 8, 2023
…n, separating the custom texture data path from the game's texture data path
iwubcode
force-pushed
the
rework_texture_cache
branch
from
7efa496
to
e101f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits 'GetTexture()' in
TextureCacheBaseinto two functions. 'GetTexture()' remains the way we look up a texture entry but a new function 'CreateTextureEntry()' is defined to handle the creation. In addition, this cleans up the hi res texture logic so that it's all in one place.There are a few advantages:
CustomTextureDatato be replaced or enhanced later (used in my PRs)