MacUI: Add stub implementation of UI::IsTestMode() #11664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a note: the artifacts confirm that this PR was built correctly (if it wasn't, the app icon would show up with a big prohibited symbol over it). |
shuffle2
reviewed
Mar 18, 2023
| @@ -139,6 +139,12 @@ void run_on_main(std::function<void()> fnc) | |||
| { | |||
| } | |||
|
|
|||
| // test-updater.py only works on Windows. | |||
There was a problem hiding this comment.
Does it actually break on mac? Only thing I can think of is that it won't modify exe/dll files on mac, but that just results in less test coverage, it should otherwise "work"?
There was a problem hiding this comment.
I guess another thing would be dealing with the bundle-ness of mac, idk what restrictions that would impose on copying the dolphin executables around and running from /tmp or whatever
There was a problem hiding this comment.
To be honest, I just assumed it didn't work. I'll try it out...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #11636.
#11636 never added an implementation of
UI::IsTestMode()inMacUI.m, which causes a linker error. Bizarrely, the build never failed despite a linker error popping up in the log. This still needs to be investigated.For now, just fix the error so that the updater can actually build again on macOS.