RetroAchievements - Add Rich Presence to Achievement Dialog Header #12028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LillyJadeKatrin
changed the title
LillyJadeKatrin
force-pushed
the
retroachievements-bugfix
branch
2 times, most recently
from
fc8f88b
to
49e041d
Compare
lioncash
reviewed
Jul 3, 2023
LillyJadeKatrin
force-pushed
the
retroachievements-bugfix
branch
from
49e041d
to
e15b573
Compare
|
I don't understand the threading model here anymore. Can DoFrame() run outside of the CPU thread? |
|
What happens if the Rich Presence is updated while the GUI is painting it? |
DoFrame should only be called by the CPU thread and shouldn't be called anywhere else, I believe. Aside from that, I don't know if I understand the concern.
I can mutex it, I think I forgot. |
LillyJadeKatrin
force-pushed
the
retroachievements-bugfix
branch
3 times, most recently
from
c7ed720
to
5890e6f
Compare
|
Needs a rebase. |
This refactors the Rich Presence generation to store to a member field that can be exposed to the UI to display the Rich Presence in the achievement header. It still updates at its original rate of once per two minutes, but calls an update on the dialog when that ticks.
LillyJadeKatrin
force-pushed
the
retroachievements-bugfix
branch
from
5890e6f
to
38bd04c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the Rich Presence generation to store to a member field that can be exposed to the UI to display the Rich Presence in the achievement header. It still updates at its original rate of once per two minutes, but calls an update on the dialog when that ticks.