VideoCommon: move texture dump to a free function #12300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
dump_texture_free_function
branch
from
70a3a9e
to
a4efc42
Compare
|
I added this as a free function to a new file called |
ghost
approved these changes
Nov 24, 2023
lioncash
reviewed
Nov 26, 2023
…wn free function so it can be used elsewhere. Doing this change may also slightly improve performance of this operation
iwubcode
force-pushed
the
dump_texture_free_function
branch
from
a4efc42
to
fb86c63
Compare
lioncash
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the texture dump logic out of the texture cache to a free function so that it can be used elsewhere if desired. Some slight changes were made that could be considered a slight performance boost when using this capability (depending on configuration).