VideoCommon: prevent a potential custom texture crash #12374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when a shared_ptr gets released while a pointer to its member data is still being used
lioncash
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom asset data is loaded on a separate thread and stored in a
shared_ptr. When something wants some of that asset data, a copy of theshared_ptrwill be provided. At any time the separate thread can destroy the originalshared_ptrcopy, meaning something that wants to use that data must keep thatshared_ptraround as long as it wants that copy of the data.In
TextureCache, I was loading ashared_ptr, getting a pointer to one of its member variables, then letting thatshared_ptrcopy die. So it was undefined how long that member pointer would be valid.A user on discord had a crash that looked eerily like it could be caused by this. This PR fixes that issue by holding onto the
shared_ptrinstead of the member pointer.