VideoCommon: update shader asset to provide a variant default value #12382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
shader_asset_default_value
branch
from
4ed1540
to
96c8172
Compare
TellowKrinkle
approved these changes
Dec 11, 2023
iwubcode
force-pushed
the
shader_asset_default_value
branch
from
96c8172
to
b69d336
Compare
|
No functional changes from Tellow's approval, just fixed a conflict from a |
lioncash
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the logic done in #12240 this adds a default value variant to the shader asset. This value will be used to populate a material when it is initially created from a shader (and allowing the user to reset a modified value to the default if desired).
We also use the type information from the variant instead of an explicit type enum.