Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameFile: Default GameBanner operator== #12388

Merged
merged 1 commit into from Dec 11, 2023
Merged

GameFile: Default GameBanner operator== #12388

merged 1 commit into from Dec 11, 2023

Conversation

lioncash
Copy link
Member

Same behavior, but less code.

@lioncash
GameFile: Default GameBanner operator==
cdf8849 
Same behavior, but less code.
@JosJuice
Copy link
Member

Do we not need an explicit operator!= anymore thanks to C++20? LGTM if so.

@lioncash
Copy link
Member Author

Yeah, as of C++20, in the face of an implemented operator==, the compiler will automatically rewrite lhs != rhs into !(lhs == rhs)

@AdmiralCurtiss AdmiralCurtiss merged commit 16ba56a into dolphin-emu:master Dec 11, 2023
11 checks passed
@lioncash lioncash deleted the compare branch December 11, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

@Dentomologist Dentomologist Dentomologist approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@lioncash @JosJuice @iwubcode @Dentomologist @AdmiralCurtiss