Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiiNetConfig: Eliminate usages of the global system accessor #12422

Merged
merged 1 commit into from Dec 14, 2023

Conversation

lioncash
Copy link
Member

We can pass in the existing system instance from the ncd/manage instance.

@AdmiralCurtiss
Copy link
Contributor

In theory these could just take memory instead, since that's already in scope at the call site. YMMV though.

We can pass in the existing memory manager instance into the functions
instead of using the global accessor to access it.
@lioncash
Copy link
Member Author

lioncash commented Dec 14, 2023

That's even better; it lets us remove the System.h include, since we already have Memmap.h included.

Switched over to that instead.

@dolphin-ci
Copy link

dolphin-ci bot commented Dec 14, 2023

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • bk-tev on mvk-osx-m1: diff
  • burnout2-vehicletextures on mvk-osx-m1: failed to render
  • djhero2-blend on mvk-osx-m1: diff
  • fishing-resort-map on mvk-osx-m1: diff
  • jb-shadow on mvk-osx-m1: diff
  • kirby-logicop on mvk-osx-m1: diff
  • lm-mario-portrait on mvk-osx-m1: diff
  • major-minor on mvk-osx-m1: diff
  • mario-golf-oob on mvk-osx-m1: diff
  • mkdd-babypark on mvk-osx-m1: diff
  • mkw-bridge on mvk-osx-m1: diff
  • mkw-flags on mvk-osx-m1: diff
  • mmx-light on mvk-osx-m1: diff
  • mp2-scanner on mvk-osx-m1: diff
  • mp3-bloom on mvk-osx-m1: diff
  • rs3-skybox2 on mvk-osx-m1: diff
  • smg-marioeyes on mvk-osx-m1: diff
  • smg-mmg on mvk-osx-m1: diff
  • smg-roar on mvk-osx-m1: diff
  • sms-water on mvk-osx-m1: diff
  • sonic-riders-blur on mvk-osx-m1: diff
  • sonic-riders-zg-4p on mvk-osx-m1: diff
  • tp-skin on mvk-osx-m1: diff
  • custom-brawl-char on mtl-osx-m1: diff
  • metroid-visor on mtl-osx-m1: diff
  • ssbb-mod-lloyd on mtl-osx-m1: diff
  • vegas-party-depth on mtl-osx-m1: diff

automated-fifoci-reporter

@AdmiralCurtiss AdmiralCurtiss merged commit 370474a into dolphin-emu:master Dec 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants