VideoCommon: handle asset memory going over reserved limit correctly #12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by erroring when the memory is exceeded and not allowing more assets to load until memory is released
iwubcode
force-pushed
the
asset_memory_limit
branch
from
e847fbe
to
b669580
Compare
|
Confirmed fixed by user |
ghost
approved these changes
Dec 27, 2023
lioncash
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assets exceeded the reserved memory limit (ex: a large texture pack), we were going over that reserved amount because we were not stopping future loads of assets from occurring (we were only reporting it). This should hopefully fix the crash that a user was seeing. Will see if they can test.