Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWindow: Fix batch mode #12831

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

TryTwo
Copy link
Contributor

@TryTwo TryTwo commented Jun 4, 2024

I accidentally broke batch mode (for keeping the main window hidden) in #12794. Hopefully that's the only thing I missed, as I don't know another way to initialize the Window before it is initialized somewhat randomly with bugs on Windows platforms.

@TryTwo
Copy link
Contributor Author

TryTwo commented Jun 5, 2024

@AdmiralCurtiss Can I get this fix merged?

It uses the same check MainWindow::Show() already does. Also, getting positive feedback on the original commit from Windows users.

@AdmiralCurtiss AdmiralCurtiss merged commit 47fae68 into dolphin-emu:master Jun 6, 2024
11 checks passed
@Owlet7
Copy link

Owlet7 commented Jun 6, 2024

Using batch mode now resets the GUI window to the smallest size on the next time when Dolphin is run normally (on Windows).

@TryTwo
Copy link
Contributor Author

TryTwo commented Jun 6, 2024

Using batch mode now resets the GUI window to the smallest size on the next time when Dolphin is run normally (on Windows).

Is that the original behavior before I changed anything?

@Owlet7
Copy link

Owlet7 commented Jun 7, 2024

Is that the original behavior before I changed anything?

Prior to 5.0-21637, the main window size and position stayed the same after using batch mode.

@TryTwo
Copy link
Contributor Author

TryTwo commented Jun 7, 2024

Is that the original behavior before I changed anything?

Prior to 5.0-21637, the main window size and position stayed the same after using batch mode.

Oh okay. It's so fragile. Is there a way to bring the UI up in batch mode? I wonder if I can tell it to just not save new UI data if in batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants