MainWindow, Bugfix: Initialize geometries before calling GetWindowSystemInfo #12794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.dolphin-emu.org/issues/11191
https://bugs.dolphin-emu.org/issues/13355
On Windows:
InitControllers() -> GetWindowSystemInfo -> wsi.render_window being set will set/save the initial geometry, which will cause sizing bugs until it's set again by the user resizing/repositioning.
Not tested on other platforms. I don't see any problem with moving InitControllers() down, but someone should double check.
If the normal sized window is very small there will still be some issues with maximized windows restoring geometry, but that's more of a Qt bug.