Fix 4.0-4901 VolumeDirectory stack overflow #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The recursive thing is probably worth a comment. |
JosJuice
force-pushed
the
volumedirectory-regression
branch
from
a03461a
to
9c5c0cb
Compare
|
Comment added. |
I actually fixed this once, but then I broke it in a failed attempt to optimize. VolumeHandler::IsWii calls CVolumeDirectory::Read(0x18, 4, &MagicWord, false);
JosJuice
force-pushed
the
volumedirectory-regression
branch
from
9c5c0cb
to
358183e
Compare
|
general PSA: osx buildbot is offline as there was a rogue squirrel which fried itself :'( (and the PC on which the osx buildbot runs wasn't set to automatically power back on after power failure). |
skidau
added a commit
that referenced
this pull request
Jan 10, 2015
Fix 4.0-4901 VolumeDirectory stack overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually fixed this once, but then I broke it in a failed attempt to optimize. VolumeHandler::IsWii calls CVolumeDirectory::Read(0x18, 4, &MagicWord, false);