D3D: More debug information and break on error #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| D3D11_MESSAGE_ID_SETPRIVATEDATA_CHANGINGPARAMS | ||
| }; | ||
|
|
||
| D3D11_INFO_QUEUE_FILTER filter; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mrgreywater
force-pushed
the
d3d-debugbreak
branch
from
3b49f5e
to
c43da7e
Compare
|
@dolphin-emu-bot rebuild That looks pretty cool. Granted, I don't know a lot about DX... @Armada651 care to review this? :) |
|
@Armada651 The memset change was done since lioncash wanted it, the comment was changed because of neobrain (see above). |
|
I think it's alright, just wanted to confirm it was intentional. |
| g_renderer->RestoreAPIState(); | ||
| D3D::stateman->Apply(); // force unbind efb texture as shader resource |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
shuffle2
added a commit
that referenced
this pull request
May 8, 2015
D3D: More debug information and break on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only affects the debug build and should give a little more information when debugging the DirectX backend. It also adds a breakpoint when otherwise the graphics driver is likely to crash. The function GetDebugObjectName is added but not used, it's helpful when trying to figure out which objects actually cause a failure.
The commits will be squashed with an appropriate message if you think this is worth adding. It certainly helped me when debugging.