DOL loader cleanup with std::vector and safety checks #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Memory::Write_U8(data_section[i][num], m_dolheader.dataAddress[i] + num); | ||
| } | ||
| } | ||
| for (int i = 0; i < m_data_sections.size(); ++i) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JosJuice
force-pushed
the
dol-cleanup
branch
4 times, most recently
from
9772d74
to
3317107
Compare
JosJuice
force-pushed
the
dol-cleanup
branch
4 times, most recently
from
7e7c234
to
cb85f13
Compare
JosJuice
force-pushed
the
dol-cleanup
branch
3 times, most recently
from
2967de5
to
48799f0
Compare
|
@JosJuice Any update? |
|
@comex Rebased. |
|
Ehhh...please do not use asserts as if they are standard error handling. |
| @@ -42,15 +44,16 @@ class CDolLoader | |||
| u32 bssAddress; | |||
| u32 bssSize; | |||
| u32 entryPoint; | |||
| u32 padd[7]; | |||
| //u32 padding[7]; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I've removed the asserts. |
Sonicadvance1
added a commit
that referenced
this pull request
May 26, 2015
DOL loader cleanup with std::vector and safety checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.