quiet some warnings which appear on vs2015. #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quieted warnings include shadowed variable names and integer extensions.
| @@ -1525,7 +1525,7 @@ void Jit64::rlwimix(UGeckoInstruction inst) | |||
| bool isRightShift = mask == (1U << inst.SH) - 1; | |||
| if (gpr.R(a).IsImm()) | |||
| { | |||
| u32 maskA = gpr.R(a).offset & ~mask; | |||
| u32 maskA = (u32)gpr.R(a).offset & ~mask; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Not entirely happy with renaming locals to start with _ instead of fixing the globals (which should start with |
|
OK, well...I think all questions are taken care of, and/or there are no blocking complaints? Someone clicky merge or say if that's not the case, thanks. |
magumagu
added a commit
that referenced
this pull request
Mar 16, 2015
quiet some warnings which appear on vs2015.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quieted warnings include shadowed variable names and integer extensions.