Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading incompatible savestate, display exact Dolphin version #2232

Merged
merged 1 commit into from
Mar 30, 2015

Conversation

JosJuice
Copy link
Member

Sometimes people don't remember what version of Dolphin was used to create a savestate. This PR makes Dolphin save its version as a string to all savestates it creates, and makes Dolphin read the version string from all savestates that were created after this feature was added. In case the user loads an incompatible savestate, a panic alert is displayed that tells the user which version of Dolphin was used to create the savestate, so that the user will be able to find that version and load the savestate.

The old "Can't load state from other revisions !" OSD message is still displayed, in addition to the new panic alert. Should the OSD message be kept, or is it better to only have the new one?

{
p.Do(version_string);
}
else

This comment was marked as off-topic.

@skidau
Copy link
Contributor

skidau commented Mar 18, 2015

Please change the PanicAlert to a OSD. PanicAlerts are to be used if Dolphin is about to crash to desktop.

@JosJuice
Copy link
Member Author

The problem with OSD messages is that you can't stop and read for as long as you want to. I guess I could try to cram the version number in while keeping the message short, but users probably want to have the version number on screen instead of having to memorize a four-digit number, and I also had a request about making the panic alert explain that a proper save should be used instead of a savestate. So while this isn't exactly the perfect way to use a panic alert, I don't think there's a better option.

@skidau
Copy link
Contributor

skidau commented Mar 18, 2015

The thing with PanicAlerts is that the user has to click the mouse button or hit the enter key on the keyboard to continue the game. This is inconvenient if they are (not near the kb/m) playing from a gamepad or wiimote.

@JosJuice
Copy link
Member Author

Yes, but it's not that inconvenient compared to having to exit Dolphin, potentially download a separate version and then run that. I don't think users try to load old savestates in the middle of gameplay often either... unless they do it by accident when trying to load another savestate? Is that a concern?

@JosJuice JosJuice force-pushed the savestate-exact-version branch 2 times, most recently from 32272ab to 3e21f9e Compare March 19, 2015 15:58
@JosJuice
Copy link
Member Author

I have now also added support for displaying approximate Dolphin versions when loading older savestates.

Oddly enough, I noticed that the panic alerts don't show up if I disable OSD messages, even if Use Panic Handlers are turned on. What's up with that?

{ 39, { "4.0-5279", "4.0-5525" } },
{ 40, { "4.0-5531", "4.0-5809" } },
{ 41, { "4.0-5811", "4.0-5923" } },
{ 42, { "4.0-5925", "4.0-????" } }

This comment was marked as off-topic.

@RachelBryk
Copy link
Member

I am not sure it is safe to assume people will always go download the old version to load their old save state rather than just give up and not use it. -1 on panicalert.

@JosJuice
Copy link
Member Author

Okay. I added it beacuse of those people who use savestates as their only method of saving, but I suppose there are a lot more users that only use savestates lightly and just do what you said. I've removed the second part of the message now, so that it only says that the savestate is incompatible and which version it was created with.

Was the "-1 on panicalert" only referring to the text in the panic alert, or the fact that there is a panic alert at all?

@RachelBryk
Copy link
Member

The fact that there is one at all. It should be an OSD message.

@JosJuice
Copy link
Member Author

Then OSD it is. There is now a second OSD message that displays the version, in addition to the existing one that says "Can't load state from other versions!"

skidau added a commit that referenced this pull request Mar 30, 2015
When loading incompatible savestate, display exact Dolphin version
@skidau skidau merged commit 8c47c68 into dolphin-emu:master Mar 30, 2015
@JosJuice JosJuice deleted the savestate-exact-version branch March 30, 2015 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants