UI improvements to Add AR Code and Add Patch windows. #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
|
Please use a more descriptive commit message/PR title. |
| @@ -178,6 +179,7 @@ void CARCodeAddEdit::UpdateTextCtrl(ActionReplay::ARCode arCode) | |||
| } | |||
| else | |||
| { | |||
| EditCheatCode->SetValue(_("Insert Encrypted or Decrypted code here...")); | |||
| //EditCheatCode->SetValue(_("Insert Encrypted or Decrypted code here...")); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Helios747
force-pushed
the
master
branch
3 times, most recently
from
f66aa16
to
0a32c8d
Compare
|
@dolphin-emu-bot rebuild |
| @@ -30,7 +30,7 @@ CARCodeAddEdit::CARCodeAddEdit(int _selection, std::vector<ActionReplay::ARCode> | |||
| Bind(wxEVT_BUTTON, &CARCodeAddEdit::SaveCheatData, this, wxID_OK); | |||
|
|
|||
| ActionReplay::ARCode tempEntries; | |||
| wxString currentName = _("Insert name here..."); | |||
| wxString currentName = _(""); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Helios747
force-pushed
the
master
branch
3 times, most recently
from
aea561e
to
321b55c
Compare
|
I think renaming the pr title to what you're actually changing would be nice. |
Helios747
changed the title
Text fields no longer have redundant text. Blank text variables no longer have redundant translation syntax. Removed redundant else condition. Fixed bug with cheat name deleting itself on edit.
|
@dolphin-emu-bot rebuild |
|
LGTM |
FioraAeterna
added a commit
that referenced
this pull request
Jun 15, 2015
UI improvements to Add AR Code and Add Patch windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the text from both textfields and added a "Code" label to describe the cheatcode field. Much cleaner.