Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AArch64] Implement fcmp{u,o} #2760

Merged
merged 1 commit into from Aug 21, 2015
Merged

[AArch64] Implement fcmp{u,o} #2760

merged 1 commit into from Aug 21, 2015

Conversation

Sonicadvance1
Copy link
Contributor

No description provided.

lioncash
lioncash reviewed Jul 21, 2015
View reviewed changes
Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
SetJumpTarget(pNaN2);
}
else
SetJumpTarget(pNaN3);

This comment was marked as off-topic.

Sign in to view

degasus
degasus reviewed Jul 21, 2015
View reviewed changes
Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
pGreater = B(CC_GT);
}

if (a != b)

This comment was marked as off-topic.

Sign in to view

@Sonicadvance1 Sonicadvance1 deleted the aarch64_fcmp branch August 9, 2015 08:03
@Sonicadvance1 Sonicadvance1 restored the aarch64_fcmp branch August 9, 2015 08:07
@Sonicadvance1 Sonicadvance1 reopened this Aug 9, 2015
@Sonicadvance1
Copy link
Contributor Author

I think it's good enough as is at the moment.
We can't do a conditional fixupbranch farther away than 1MB so it's difficult to move bits of it to farcode without adding a lot more branches, and these little Cortex-A57s take performance penalties if there are more than 1 branch instruction within 16 bytes of each other. So the less branches the better here.

If someone wants to improve it in the future that would be great, I'm busy working on other things atm.

@Sonicadvance1
Copy link
Contributor Author

I'll most likely come back to optimize this in the future. I still think there are some things that can be done, but currently it is better purely to have it implemented than not.

@Sonicadvance1
Copy link
Contributor Author

This actually doesn't depend on the other PR due to how that PR is implemented.

degasus added a commit that referenced this pull request Aug 21, 2015
@degasus
Merge pull request #2760 from Sonicadvance1/aarch64_fcmp
4f45d71 
[AArch64] Implement fcmp{u,o}
@degasus degasus merged commit 4f45d71 into dolphin-emu:master Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Sonicadvance1 @lioncash @degasus