Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Visual Studio 2015 #2762

Merged
merged 9 commits into from
Sep 3, 2015
Merged

Move to Visual Studio 2015 #2762

merged 9 commits into from
Sep 3, 2015

Conversation

shuffle2
Copy link
Contributor

Currently this PR is in tiny commits so they can be looked at easily.
Once reviewed it will be squashed down.

@shuffle2
Copy link
Contributor Author

blocked on #2218

@waddlesplash
Copy link
Contributor

@shuffle2: FWIW, with latest VS2015, I just merged this into master locally and it built with no additional changes. Maybe the issues are solved?

@waddlesplash
Copy link
Contributor

Other than the volatile problems, LGTM.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Sep 3, 2015

The commit is ready now, once @Parlane fixes the buildbot this should be merged to keep master building.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Sep 3, 2015

After reviewing the state of CRT libraries going forward, I decided not to package parts of it with dolphin anymore (the so-called "app-local deployment" method). App-local deployment was originally not going to be supported at all but as of VS2015 RTM, support is maintained.
So while it's technically possible to do, I think it is much better to go with the "proper" method of telling people to run VCRedist (vcredist_x64.exe in our case). We could package this with dolphin, host it somewhere, or just give people instructions. Doing it this way ensures dolphin references the most up-to-date version of the binaries, prevents us from having to ship dozens(!) of DLLs with dolphin, and automatically deploys the correct files for the version of windows they're running on. I also doubt dolphin will be the first app doing this that people will try to execute, so it's likely most people won't even notice.

shuffle2 added a commit that referenced this pull request Sep 3, 2015
Move to Visual Studio 2015
@shuffle2 shuffle2 merged commit f83f3cf into dolphin-emu:master Sep 3, 2015
@MayImilae
Copy link
Contributor

They'll notice. They will SO notice!

@shuffle2 shuffle2 deleted the vs14 branch April 2, 2016 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants